[Dependency Scanning] Add tracking of the number of dependency queries and emit them as remarks #86079
Conversation
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov,
tshortli and
xedin
as code owners
|
@swift-ci test |
|
|
||
| // CHECK-REMARK-SAVE: remark: Number of Swift module queries: '21' | ||
| // CHECK-REMARK-SAVE: remark: Number of named Clang module queries: '6' | ||
| // CHECK-REMARK-SAVE: remark: Number of recorded Clang module dependencies queried by-name from a Swift client: '6' |
There was a problem hiding this comment.
Although it may be prudent to, one day, make the compiler assert/error if the number of queries exceeds the number of recorded by-name Clang dependencies, we are not quite there yet. I have a couple of follow-up changes in the pipeline which should remove further sources of duplicate queries.
|
I guess you forgot to add the Options.td change. I assume I suggested remarks. The other option is to using |
artemcm
force-pushed
the
DependencyScanningMetrics
branch
from
7fed579 to
1349167
Compare
I think remarks fit okay. I have long wanted the scanner to emit more-detailed overall remarks about the work it is doing and putting in all the plumbing this PR adds will make that easier to build on. |
|
@swift-ci test |
| std::shared_ptr<llvm::cas::ActionCache> ActionCache; | ||
|
|
||
| // Metrics about actions performed by the scanner | ||
| std::shared_ptr<ScannerMetrics> scanMetrics; |
There was a problem hiding this comment.
I don't see why this needs to be shared_ptr and same for all other ScannerMetrics references. CAS is shared_ptr mainly because of the APIs from llvm/clang need that. And here it can always just be a reference to ScannerMetrics in ModuleDependencyScanner, or maybe even move to DependencyScannerDiagnosticReporter (where it can decide if it needs to increment the counter and report the metrics based on the flag).
There was a problem hiding this comment.
That's fine, I moved the metrics into DependencyScannerDiagnosticReporter and added methods to it which will increment the appropriate counter if remark emission is enabled.
artemcm
force-pushed
the
DependencyScanningMetrics
branch
2 times, most recently
from
5e76a2f to
bff1749
Compare
|
@swift-ci test |
artemcm
force-pushed
the
DependencyScanningMetrics
branch
from
bff1749 to
eca8925
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
DependencyScanningMetrics
branch
from
eca8925 to
e6761b1
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux platform |
…s and emit them as remarks This change adds collection of three metrics to the scanner: - number of Swift module lookups - number of named Clang module lookups - recorded number of Clang modules which were imported into a Swift module by name It introduces '-Rdependency-scan', which acts as a super-set flag to the existing '-Rdependency-scan-cache' and adds emission of the above metrics as remarks when this flag is enabled. Followup changes will add further remarks about dependency scanner progress.
artemcm
force-pushed
the
DependencyScanningMetrics
branch
from
e6761b1 to
7017034
Compare
|
@swift-ci smoke test |
2 participants
This change adds collection of three metrics to the scanner:
It re-uses the prior '-Rdependency-scan-cache', renaming it to '-Rdependency-scan' and adds emission of the above metrics as remarks when this flag is enabled. Followup changes will add further remarks about dependency scanner progress.